[Passed] A grant to make NuBot work with Liquidity Pools

[desrever]

the largest offset supported by the pool isn’t 0.01?

@masterOfDisaster responded this

I am trying to test southX since it is the only exchange without LP support but i am getting an SSL error.

Fix coming soon

why don’t you make the tolerance like 5% so that testers are not in danger of losing funds due to small spread.

@Nagalim is right, for testing purposes I reccomend using wider spreads (editing OP) . You can obtain them by changing these config parameters

"bookSellOffset": 
"bookBuyOffset"

[desrever]

@zoro I can’t reproduce your issue.

Could you please post your config (make sure to omit api keys) and paste the full log of the error?

Thanks.

PS: have you noticed southxchange uses a swapped pair (NBT-denominated)? This changes the game quite a bit, make sure you set the right params

[zoro]

This is my config:

{
“apiKey”: “xxxx”,
“apiSecret”: “xxxx”,
“mailRecipient”: “xxxx”,
“exchangeName”: “SouthXChange”,
“dualSide”: true,
“pair”: “nbt_btc”,
“rpcUser”: “zoro”,
“rpcPass”: “xxxx”,
“nubitAddress”: “xxxx”,
“nudPort”: 9091,
“bypassStreaming”: true,
“nudIp”: “127.0.0.1”,
“mailnotifications”: “SEVERE”,
“submitLiquidity”: false,
“executeOrders”: true,
“verbosity”: “NORMAL”,
“gitter”: true,
“multipleOperators”: false,
“txFee”: 0.1,
“priceIncrement”: 0.002,
“emergencyTimeout”: 60,
“keepProceeds”: 0.0,
“wallchangeThreshold”: 0.1,
“webport”: 9995,
“bookDisabletier2”: true,
“bookSellwall”: 1500.0,
“bookBuywall”: 1500.0,
“bookSellOffset”: 0.015,
“bookBuyOffset”: 0.015,
“bookSellMaxVolumeCumulative”: 6000.0,
“bookBuyMaxVolumeCumulative”: 6000.0,
“bookBuyInterval”: 0.002,
“bookSellInterval”: 0.002,
“bookSellType”: “EXP”,
“bookBuyType”: “EXP”,
“bookSellSteepness”: “HIGH”,
“bookBuySteepness”: “HIGH”,
“poolModeActive”: false,
“poolURI”: “”,
“poolPayoutAddress”: “”,
“poolSubmitInterval”: 50,
“mainFeed”: “blockchain”,
“backupFeeds”: [
“bitfinex”,
“bitstamp”
]
}

and the standard log:
19:57:14.679 INFO - defined session log path logs/bot_sessions/0.4.1-RC1_1456768634679_4655db - [c.n.n.bot.Global:116]
19:57:14.814 INFO - Session ID = 0.4.1-RC1_1456768634679_4655db - [c.n.n.b.NuBotBase:85]
19:57:14.843 INFO - Set up SSL certificates - [c.n.n.b.NuBotBase:168]
19:57:14.860 INFO - installKeystore. trustall: false - [c.n.n.u.Utils:346]
19:57:14.880 INFO - Reading keystorefile from : /C:/nu/nubot41RC1/res/ssl/nubot_keystore.jks - [c.n.n.u.Utils:361]
19:57:14.908 ERROR - java.lang.NullPointerException - [c.n.n.e.ExchangeFacade:173]
19:57:14.924 INFO - Swapped pair mode : false - [c.n.n.b.NuBotBase:205]

[desrever]

As I said earlier, the pair is swapped :

"pair": "btc_nbt",

EDIT: and lowercase exchange name

"exchangeName": "southxchange",

[zoro]

It is working now. The order type and quantity is a little bit weird though

[desrever]

RC2 available @ https://bitbucket.org/JordanLeePeershares/nubottrading/downloads/nubot-v0.4.1-RC2.zip

[masterOfDisaster]

Also notifying the HR department with a tag

I made preparations to release funds from the multisig address as soon as 0.4.1 is considered complete.

Would you call it safe to provide liquidity with 0.4.1-RC2 on Poloniex?
I wouldn’t dare doing that unless I get a go from you, but I have no idea how stable and reliable RC2 is.

[desrever]

Would you call it safe to provide liquidity with 0.4.1-RC2 on Poloniex?

Stability wise this would be as safe as 0.3.2a. I can’t and I won’t vouch my life on it, because software is software, but I am confident it will behave. I’ve done tests myself and so did @willy, if I recall correctly.

[masterOfDisaster]

I’m not asking for your life

Stability wise this would be as safe as 0.3.2a

is sufficient for me.

This is new, right?

20:20:54.211 [checkNud] WARN  - Nu client is locked and will not be able to submit liquidity info.
Use walletpassphrase <yourpassphrase> 9999999 to unlock it [c.n.n.R.NudClient:116]

btw.

walletpassphrase <yourpassphrase> 9999999 true

is working as well.

Poloniex NuBot upgraded to 0.4.1-RC2 and running:

20:23:32.880 [checkOrders] WARN  - Liquidity info submitted:
        tier=1 buy=1500.00000146 sell=1500.0 identifier=1:NBTBTC:poloniex:0.4.1-RC2_1457381857080_9340b0 response=true
        tier=2 buy=12939.9 sell=4195.9615718 identifier=2:NBTBTC:poloniex:0.4.1-RC2_1457381857080_9340b0 response=true [c.n.n.t.CheckOrdersTask:142]

[desrever]

Testing period is over : NuBot 0.4.1 tagged and released.
Will make a write up soon in the release thread.

I also invite 2/3 of the HR department to execute the payment transaction
(@erasmospunk @masterOfDisaster and @woolly_sammoth ) on BJpNkPBsWpKDpqXh5BMamWeJg5eZ2bbkqi .

Also provide me with a NBT address to pay for this custodian service.

[masterOfDisaster]

I suppose you needed the full 3,000 NBT, right (It’s in fact only 2999.7128 on the multisg address)?
And I suppose you ask for custodian addresses, because of the 20 NBT fee.

Might we just transfer all funds to you and you distribute the 20 NBT to the custodians and burn leftover funds?
Otherwise I adjust the transaction to send the 20 NBT to the custodians as soon as addresses are available.

Transfer of 2999.7028 NBT to @desrever’s address BJpNkPBsWpKDpqXh5BMamWeJg5eZ2bbkqi; signed 1 of 2/3

010000002f71e05603e721f506d7e3099d425a7f64e5a2bf46098f438b1569afc113ee4203cc39834f00000000b4004730440220178196895419d55919e171ca12373a5640fa1a98be5e517aea03494ef20fb9330220429c9d157e6f7b17ab3e47b0a3532e43d597c13816616a0cca30b420f4e07cba014c69522102b63cdb28bcf157a6dcc6ac6898ef30e30f90daabe452a56d990e8f4dda60d47f2102f36739e94e6711be56ae9754359cd05785fec9f20025e3038b9cc87b641a0ab02102966e15963037554dca00c288dac203c78593fcc24bc739ce1cf9f3de963480bb53aeffffffff4bb70d92a5188f1358cdf04b8ef7135095bd7787b628d7f59e28c3aad5904d7101000000b5004830450221008583ea81d6f7ff349c3af6cb0b2daf1a0957871ae18cca1b8682a2060a810eb302204d54d2f94241deae67f2079698982c241886413f3c059eace3ba0e2c2eb7f2b5014c69522102b63cdb28bcf157a6dcc6ac6898ef30e30f90daabe452a56d990e8f4dda60d47f2102f36739e94e6711be56ae9754359cd05785fec9f20025e3038b9cc87b641a0ab02102966e15963037554dca00c288dac203c78593fcc24bc739ce1cf9f3de963480bb53aeffffffff42d7e3c6115fd05fb21dee0f6cd0f36badcc597d66aed8eb6b8dc178ee57679b00000000b500483045022100a56544175c09fd962feab0743f179faf60e37581572aec87a22fd534d62bef49022069dbdcfc9dfd7d24dfcc7d3af2c97df5cddc1455654b7e4eeeca6721ff34863a014c69522102b63cdb28bcf157a6dcc6ac6898ef30e30f90daabe452a56d990e8f4dda60d47f2102f36739e94e6711be56ae9754359cd05785fec9f20025e3038b9cc87b641a0ab02102966e15963037554dca00c288dac203c78593fcc24bc739ce1cf9f3de963480bb53aeffffffff01e4b7c901000000001976a9149d98cc235b5e5666281c69939375617de52d366188ac0000000042

Please use my address form the multisg for sending me the 20 NBT (BMuw3ZGFvQd5syVLBz8ywCUin6GXsZbHXN)

[desrever]

I suppose you needed the full 3,000 NBT, right (It’s in fact only 2999.7128 on the multisg address)?

Correct. All entries and tasks are tracked. I went over limits and stopped tracking time

Might we just transfer all funds to you and you distribute the 20 NBT to the custodians and burn leftover funds?

yep, if you think it makes sense.

[erasmospunk]

Everything looks good (quickly skimmed the code) so I co-signed and broadcast the transaction.

@desrever could you please burn as fees the 20NBT reward and post the transaction.

(A comment regarding these kind of contracts, it would be nice if I got a notification from my wallet with a link of this thread and a button to easily allow me to co-sign. For example the Copay wallet sends you co-signing notifications but it isn’t a cross-wallet system. We need some kind of a standard.)

[desrever]

Received the payment. Thank you all for the support, now I am all ears while receiving bug reports.

20 NBT tx to mod http://blockexplorer.nu/transactions/a0eff85a3a974199b429c8d79b5381ba603c0ed0c05b5c369ea50c9bbebf312f

20 NBT burned

http://blockexplorer.nu/transactions/3f9fe26865640c3feb2df03f6a46c8d87bd5e235838299d05c05c7260e725b2b

[zoro]

Testing nubot RC2 as a sell side gateway in SouthX, i cannot place orders after NBT --> US-NBT.
Should i wait for a new revision?
thanks

[masterOfDisaster]

With a kind of checklist NuBot operators (gateway operators, ALPv2 clients) could provide valuable feedback for the NuBot dev team.
Let me try running a NuBot at SouthX as well. I think you are right with your assessment. A second test wouldn’t hurt, though.

[masterOfDisaster]

@desrever, @woolly_sammoth, I can reproduce trouble running NuBot 0.4.1 on southxchange:

2016-04-03 20:57:16,372 ERROR - ApiError [1 :  Invalid market] - [priceTriggerTask - c.n.n.s.S.StrategySecondaryPegUtils:391]
[...]
2016-04-03 20:59:35,817 INFO  - Cannot find a balance for currency with code NBT or BTC in your balance. NuBot assumes that balance is 0 - [checkOrders - c.n.n.t.w.SouthxchangeWrapper:173]
[...]
2016-04-03 21:01:48,389 WARN  - Liquidity info submitted:
        tier=1 buy=0.0 sell=0.0 identifier=1:NBTBTC:southxchange:0.4.1_1459716287133_9aaac8 response=true
        tier=2 buy=4.07 sell=0.0 identifier=2:NBTBTC:southxchange:0.4.1_1459716287133_9aaac8 response=true [checkOrders - c.n.n.t.CheckOrdersTask:142]

The liquidity is broadcast correctly, but I’m not able to create T1 orders.

nud getliquiditydetails B | grep BETwD8nSjtj9ADSvej2na34xmsMYwPRymv -A 400 | grep 0.4.1_1459716287133_9aaac8 -A 2
        "1:NBTBTC:southxchange:0.4.1_1459716287133_9aaac8" : {
            "buy" : 0.0,
            "sell" : 0.0
--
        "2:NBTBTC:southxchange:0.4.1_1459716287133_9aaac8" : {
            "buy" : 4.07,
            "sell" : 0.0

As I’m not able to create issues at Bitbucket, I created the issue here

[huafei]

@masterOfDisaster any tip to run the second nubot at one machine ?

[masterOfDisaster]

Sure - create a new directory for the second NuBot and extract the archive with NuBot there.
Or simply clone the current NuBot directory.
Adjust the config file.
Run it.
If you are on a Linux shell only machine, you might find the application screen convenient.

[desrever]

Thanks for the bug report. I can make a simple patch, will do this afternoon and also check for the same on CCEDK while I am there.